hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Dimiduk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10841) Scan setters should consistently return this
Date Wed, 26 Mar 2014 17:27:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948178#comment-13948178
] 

Nick Dimiduk commented on HBASE-10841:
--------------------------------------

It looks like this task should cascade to all implementations of {{Attributes}}, which includes
at least: {{OperationWithAttributes}}, {{Query}}, {{Scan}}, {{InternalScan}} and {{Get}}.
Does that sound familiar, [~anoop.hbase]?

> Scan setters should consistently return this
> --------------------------------------------
>
>                 Key: HBASE-10841
>                 URL: https://issues.apache.org/jira/browse/HBASE-10841
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client, Usability
>    Affects Versions: 0.99.0
>            Reporter: Nick Dimiduk
>            Priority: Minor
>
> While addressing review comments on HBASE-10818, I noticed that our {{Scan}} class is
inconsistent with it's setter methods. Some of them return {{this}}, other's don't. They should
be consistent. I suggest making them all return {{this}}, to support chained invocation.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message