hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10824) Enhance detection of protobuf generated code in line length check
Date Wed, 26 Mar 2014 04:06:17 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947532#comment-13947532
] 

ramkrishna.s.vasudevan commented on HBASE-10824:
------------------------------------------------

+1 on this.  Many patches were getting reported as > 100 lines.

> Enhance detection of protobuf generated code in line length check
> -----------------------------------------------------------------
>
>                 Key: HBASE-10824
>                 URL: https://issues.apache.org/jira/browse/HBASE-10824
>             Project: HBase
>          Issue Type: Task
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>             Fix For: 0.99.0
>
>         Attachments: 10824-v1.txt
>
>
> In review of HBASE-5175, Anoop found that long line detection wasn't very effective for
protobuf generated code.
> Here is one example:
> {code}
> -1 lineLengths. The patch introduces the following lines longer than 100:
> + private DoubleMsg(boolean noInit)
> { this.unknownFields = com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }
> {code}
> This is current filter:
> {code}
>   lines=`cat $PATCH_DIR/patch | grep "^+" | grep -v "^@@" | grep -v "^+++" | grep -v
"import" | grep -v "hbase.protobuf.generated" | awk -v len="$MAX_LINE_LENGTH_PATCH"    'length
($0) > len' | head -n 10`
> {code}
> 'com.google.protobuf.' should be considered as well.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message