hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Dimiduk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10817) Add some tests on a real cluster for replica: multi master, replication
Date Tue, 25 Mar 2014 01:04:24 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13945953#comment-13945953
] 

Nick Dimiduk commented on HBASE-10817:
--------------------------------------

{noformat}
+  public static class SlowMeCopro extends BaseRegionObserver
{noformat}

This looks similar to the Coproc in TestReplicasClient. Maybe there's some reuse between them,
or a shared library of coprocs for tests?

{noformat}
+    hdt.setRegionReplication(2);
{noformat}

nit: Should just use the constant {{NB_SERVERS}}?

{noformat}
+    HTU.getHBaseAdmin().disableTable(hdt.getTableName());
+    HTU.getHBaseAdmin().modifyTable(hdt.getTableName(), hdt);
+    HTU.getHBaseAdmin().enableTable(hdt.getTableName());
{noformat}

disableTable and enableTable are both synchronous, but modifyTable is asynchronous. Is there
a race here? Better to wait for modify to complete? I'm not exactly sure about this, so I
added a modifyTableSync in HBASE-10791 and moved/reused it in HBASE-10818.

{noformat}
+    while (!ok) {
{noformat}

Better to add some kind of max iteration count here to protect our poor jenkins box from itself.

> Add some tests on a real cluster for replica: multi master, replication
> -----------------------------------------------------------------------
>
>                 Key: HBASE-10817
>                 URL: https://issues.apache.org/jira/browse/HBASE-10817
>             Project: HBase
>          Issue Type: Bug
>          Components: master, regionserver, Replication
>    Affects Versions: hbase-10070
>            Reporter: Nicolas Liochon
>            Assignee: Nicolas Liochon
>            Priority: Minor
>             Fix For: hbase-10070
>
>         Attachments: 10817.v1.patch, 10817.v2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message