hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ding Yuan (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HBASE-10813) Possible over-catch of exceptions
Date Mon, 24 Mar 2014 02:04:42 GMT
Ding Yuan created HBASE-10813:
---------------------------------

             Summary: Possible over-catch of exceptions
                 Key: HBASE-10813
                 URL: https://issues.apache.org/jira/browse/HBASE-10813
             Project: HBase
          Issue Type: Improvement
          Components: regionserver, util
    Affects Versions: 0.96.1
            Reporter: Ding Yuan


There are a few cases found by a tool that are possibly over-catch of exceptions, especially
those that will abort the server. Over-catching these exceptions may unexpectedly abort the
server, and may cause problems in the future when code in the try-block evolves. I am attaching
a patch against trunk that constrains the catch blocks to the exact exceptions that were thrown.


My tool actually found one more case in 0.96.1, but I found it has already been fixed in trunk:
{noformat}
Line: 1175, File: "org/apache/hadoop/hbase/master/SplitLogManager.java"
1173:             try {
1174:               Thread.sleep(20);
1175:-            } catch (Exception ignoreE) {
1175:+           } catch (InterruptedException e) {
1176:               // ignore
1177:             }
{noformat}

Any feedbacks are much appreciated!



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message