hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10802) CellComparator.compareStaticIgnoreMvccVersion compares type wrongly
Date Mon, 24 Mar 2014 18:52:48 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13945521#comment-13945521
] 

Andrew Purtell commented on HBASE-10802:
----------------------------------------

0.96 seems to need more than 0.98 or trunk:

{code}
Index: hbase-common/src/main/java/org/apache/hadoop/hbase/CellComparator.java
===================================================================
--- hbase-common/src/main/java/org/apache/hadoop/hbase/CellComparator.java      (revision
1579464)
+++ hbase-common/src/main/java/org/apache/hadoop/hbase/CellComparator.java      (working copy)
@@ -197,11 +197,11 @@
     if (c != 0) return c;
 
     //timestamp: later sorts first
-    c = -Longs.compare(a.getTimestamp(), b.getTimestamp());
+    c = Longs.compare(b.getTimestamp(), a.getTimestamp());
     if (c != 0) return c;
 
     //type
-    c = (0xff & a.getTypeByte()) - (0xff & b.getTypeByte());
+    c = (0xff & b.getTypeByte()) - (0xff & a.getTypeByte());
     return c;
   }
{code}

Ping [~stack]


> CellComparator.compareStaticIgnoreMvccVersion compares type wrongly
> -------------------------------------------------------------------
>
>                 Key: HBASE-10802
>                 URL: https://issues.apache.org/jira/browse/HBASE-10802
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.96.2, 0.98.1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Critical
>             Fix For: 0.98.1, 0.99.0
>
>         Attachments: HBASE-10802.patch
>
>
> Should have got this in HBASE-10749.  Missed this.  So raising a new JIRA.  Sorry about
that.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message