hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange
Date Mon, 24 Mar 2014 09:38:43 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13944845#comment-13944845
] 

ramkrishna.s.vasudevan commented on HBASE-10771:
------------------------------------------------

bq. If u strongly feel otherwise I can change.
I would prefer putInt, putShort() still.  The layer using that can easily know what it is
doing.
bq.Not sure.. I feel these should go to some sort of comparator impl.
May be the name comapre is not right? But it may be needed in place where a given byte[] is
checked against the BR contents.  For eg in the HfileBlock we compare the HFileBlock's byte[]
with a magic array.  So in such cases we need this.  So it is not necessary a different type
of comparator.

> Primitive type put/get APIs in ByteRange 
> -----------------------------------------
>
>                 Key: HBASE-10771
>                 URL: https://issues.apache.org/jira/browse/HBASE-10771
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 0.99.0
>
>         Attachments: HBASE-10771.patch
>
>
> While doing HBASE-10713 I came across the need to write int/long (and read also) from
a ByteRange.  CellBlocks are backed by ByteRange. So we can add such APIs.
> Also as per HBASE-10750  we return a ByteRange from MSLAB and also discussion under HBASE-10191
suggest we can have BR backed HFileBlocks etc.  



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message