hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matteo Bertozzi (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-10766) SnapshotCleaner allows to delete referenced files
Date Sun, 16 Mar 2014 20:20:45 GMT

     [ https://issues.apache.org/jira/browse/HBASE-10766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Matteo Bertozzi updated HBASE-10766:
------------------------------------

    Description: 
The SnapshotFileCache is checking the lastModificationTime() of the ".hbase-snapshot" directory.
But in this way "pending" snapshots created in temp are not considered.
since only the parent directory timestamp is updated.

so, if we create .hbase-snapshot/.tmp/SNAPSHOT_NAME the lastModification timestamp of .hbase-snapshot
will not be updated

https://github.com/apache/hbase/blob/af62395ef3f7e2a8be2ab16d272e5245902d7864/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java#L197

  was:
The SnapshotFileCache is checking the lastModificationTime() of the ".hbase-snapshot" directory.
But in this way "pending" snapshots created in temp are not considered.
since only the parent directory timestamp is updated.

so... if we create .hbase-snapshot/.tmp/SNAPSHOT_NAME the lastModification timestamp of .hbase-snapshot
will not be updated

https://github.com/apache/hbase/blob/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java#L197


> SnapshotCleaner allows to delete referenced files
> -------------------------------------------------
>
>                 Key: HBASE-10766
>                 URL: https://issues.apache.org/jira/browse/HBASE-10766
>             Project: HBase
>          Issue Type: Bug
>          Components: snapshots
>    Affects Versions: 0.98.0, 0.96.1.1, 0.94.17
>            Reporter: Matteo Bertozzi
>            Assignee: bharath v
>             Fix For: 0.96.2, 0.94.18, 0.98.2
>
>
> The SnapshotFileCache is checking the lastModificationTime() of the ".hbase-snapshot"
directory.
> But in this way "pending" snapshots created in temp are not considered.
> since only the parent directory timestamp is updated.
> so, if we create .hbase-snapshot/.tmp/SNAPSHOT_NAME the lastModification timestamp of
.hbase-snapshot will not be updated
> https://github.com/apache/hbase/blob/af62395ef3f7e2a8be2ab16d272e5245902d7864/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java#L197



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message