hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Daniel Cryans (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-10755) MetricsRegionSourceImpl creates metrics that start with a lower case
Date Mon, 17 Mar 2014 22:40:45 GMT

     [ https://issues.apache.org/jira/browse/HBASE-10755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Jean-Daniel Cryans updated HBASE-10755:

       Resolution: Fixed
    Fix Version/s: 0.99.0
     Release Note: There used to be a mix of metrics starting with "namespace_" "and Namespace_",
now all the metrics will use the latter.
     Hadoop Flags: Incompatible change,Reviewed
           Status: Resolved  (was: Patch Available)

Thanks Stack, committed to trunk only.

I marked this as an incompatible change since it could break some installs that were relying
on the broken behavior. I did check with one major user and they were just lower casing everything.

> MetricsRegionSourceImpl creates metrics that start with a lower case
> --------------------------------------------------------------------
>                 Key: HBASE-10755
>                 URL: https://issues.apache.org/jira/browse/HBASE-10755
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.96.0
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>            Priority: Minor
>             Fix For: 0.99.0
>         Attachments: HBASE-10755.patch
> Noticed something while looking at MBeans; some metric names are capitalized while others
aren't. This has the unwanted property of changing the metric names sorting. For example:
> Namespace_default_table_t_region_0122d54a90c9dc191857daf11e8a047d_metric_scanNext_num_ops
> namespace_default_table_t_region_0122d54a90c9dc191857daf11e8a047d_metric_appendCount
> The reason for this is that {{MutableHistogram}} uses {{StringUtils.capitalize()}} on
the metrics name (as create by {{MetricsRegionSourceImpl}} with "namespace_").
> I'm not sure what the intent was with capitalization, but either way it's a simple fix.

This message was sent by Atlassian JIRA

View raw message