hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Daniel Cryans (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10755) MutableHistogram is capitalizing the metric names
Date Mon, 17 Mar 2014 15:57:43 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937942#comment-13937942
] 

Jean-Daniel Cryans commented on HBASE-10755:
--------------------------------------------

[~stack] sure can, I just don't know which way to go. Is there a valid reason why the histograms
are upper casing the metrics? Looking over at the java.lang MBeans, it seems to be the norm
to upper case. But then Master.Server is all lower case, Master.Balancer is mostly upper case,
but at least we don't get it mixed up for the same metric prefixes. I guess I'll got with
changing "namespace_" to "Namespace_".

> MutableHistogram is capitalizing the metric names
> -------------------------------------------------
>
>                 Key: HBASE-10755
>                 URL: https://issues.apache.org/jira/browse/HBASE-10755
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.96.0
>            Reporter: Jean-Daniel Cryans
>            Priority: Minor
>
> Noticed something while looking at MBeans; some metric names are capitalized while others
aren't. This has the unwanted property of changing the metric names sorting. For example:
> Namespace_default_table_t_region_0122d54a90c9dc191857daf11e8a047d_metric_scanNext_num_ops
> namespace_default_table_t_region_0122d54a90c9dc191857daf11e8a047d_metric_appendCount
> The reason for this is that {{MutableHistogram}} uses {{StringUtils.capitalize()}} on
the metrics name (as create by {{MetricsRegionSourceImpl}} with "namespace_").
> I'm not sure what the intent was with capitalization, but either way it's a simple fix.
[~eclark]?



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message