hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10750) Pluggable MemStoreLAB
Date Thu, 20 Mar 2014 17:09:45 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13941970#comment-13941970
] 

stack commented on HBASE-10750:
-------------------------------

Why this not an implementation detail of the MemStore implementation?

There is a presumption that the allocation is giving back bytes that the KV has to itself
exclusively.  We'll change this in other implementations?

Why move the synchronization?  Arent' the old and the new equivalent?

Are these implementation details rather than generic across all MSLABs?  If so, should be
moved into the implementation:

+  String CHUNK_SIZE_KEY = "hbase.hregion.memstore.mslab.chunksize";
+  int CHUNK_SIZE_DEFAULT = 2048 * 1024;
+  String MAX_ALLOC_KEY = "hbase.hregion.memstore.mslab.max.allocation";



LGTM




> Pluggable MemStoreLAB
> ---------------------
>
>                 Key: HBASE-10750
>                 URL: https://issues.apache.org/jira/browse/HBASE-10750
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>         Attachments: HBASE-10750.patch, HBASE-10750_V2.patch
>
>
> This can allow one to have offheap MSLAB also. 
> The allocate() returns a byte[] now. This has to be changed to ByteRange so that the
impl can return on heap byte[] backed BR or offheap buffer backed BR.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message