hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jimmy Xiang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10739) RS web UI NPE if master shuts down sooner
Date Thu, 13 Mar 2014 22:33:45 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13934232#comment-13934232
] 

Jimmy Xiang commented on HBASE-10739:
-------------------------------------

The method name doesn't match the class name. Will fix it.

{quote}
 This is safe?
    if (hrs != null) tmpl.render(resp.getWriter(), hrs);
    + tmpl.render(resp.getWriter(), hrs);
{quote}

Yes, it is safe. Here, hrs is never null.


> RS web UI NPE if master shuts down sooner
> -----------------------------------------
>
>                 Key: HBASE-10739
>                 URL: https://issues.apache.org/jira/browse/HBASE-10739
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>         Attachments: hbase-10739.patch
>
>
> This is similar to HBASE-9294. However, the fix in HBASE-9294 can't fix the issue.  hrs
is unlikely null over there since we have an assert earlier. We also called hrs.isOnline eariler.
> It is very likely the master shuts down sooner so the master address is null instead.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message