hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10693) Correct declarations of Atomic* fields from 'volatile' to 'final'
Date Sat, 08 Mar 2014 05:15:49 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13924730#comment-13924730
] 

Hudson commented on HBASE-10693:
--------------------------------

SUCCESS: Integrated in HBase-0.98 #210 (See [https://builds.apache.org/job/HBase-0.98/210/])
HBASE-10693 Correct declarations of Atomic* fields from 'volatile' to 'final' (Honghua) (tedyu:
rev 1575058)
* /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
* /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java


> Correct declarations of Atomic* fields from 'volatile' to 'final'
> -----------------------------------------------------------------
>
>                 Key: HBASE-10693
>                 URL: https://issues.apache.org/jira/browse/HBASE-10693
>             Project: HBase
>          Issue Type: Improvement
>          Components: io, master
>            Reporter: Feng Honghua
>            Assignee: Feng Honghua
>            Priority: Minor
>             Fix For: 0.98.1, 0.99.0
>
>         Attachments: HBASE-10693-trunk_v1.patch
>
>
> By checking the usage of these Atomic* fields, they themselves don't change once being
assigned to referencing an Atomic* object, so 'final' rather than 'volatile' is more proper.
> On the other hand, the 'value' encapsulated in Atomic* is already declared 'volatile',
which guarantees to perform correctly in multi-threads scenarios.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message