hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Feng Honghua (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10693) Correct declarations of Atomic* fields from 'volatile' to 'final'
Date Thu, 06 Mar 2014 06:10:43 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13922055#comment-13922055

Feng Honghua commented on HBASE-10693:

bq.Any other such cases in the code base? 
Should no other such cases... I used  *grep  \-rn  'volatile.\*Atomic'  hbase-\*/src/main/java*
 and only those two places found

> Correct declarations of Atomic* fields from 'volatile' to 'final'
> -----------------------------------------------------------------
>                 Key: HBASE-10693
>                 URL: https://issues.apache.org/jira/browse/HBASE-10693
>             Project: HBase
>          Issue Type: Improvement
>          Components: io, master
>            Reporter: Feng Honghua
>            Assignee: Feng Honghua
>            Priority: Minor
>         Attachments: HBASE-10693-trunk_v1.patch
> By checking the usage of these Atomic* fields, they themselves don't change once being
assigned to referencing an Atomic* object, so 'final' rather than 'volatile' is more proper.
> On the other hand, the 'value' encapsulated in Atomic* is already declared 'volatile',
which guarantees to perform correctly in multi-threads scenarios.

This message was sent by Atlassian JIRA

View raw message