hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matteo Bertozzi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8963) Add configuration option to skip HFile archiving
Date Mon, 17 Mar 2014 16:29:45 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937986#comment-13937986

Matteo Bertozzi commented on HBASE-8963:

instead of admin.disableTable() + admin.deleteTable() you can use TEST_UTIL.deleteTable()
that does both for you.

getTableRowCount() exists already in TEST_UTIL.countRows(), there is also SnapshotTestingUtils.verifyRowCount(TEST_UTIL,
tableName, expectedRows) that does the count + assert for you.

nit on formatting: there are a couple of places like "a,b, c" and a couple of places with
4 spaces instead of 2 I think..

test failures seems not related but there is a new report from findbug, you can find the details
in the link above. 

other than that looks good to me, did you do some manual verification?
can you post the steps and the conf settings.

> Add configuration option to skip HFile archiving
> ------------------------------------------------
>                 Key: HBASE-8963
>                 URL: https://issues.apache.org/jira/browse/HBASE-8963
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: bharath v
>             Fix For: 0.99.0
>         Attachments: HBASE-8963.trunk.v1.patch, HBASE-8963.trunk.v2.patch, HBASE-8963.trunk.v3.patch,
HBASE-8963.trunk.v4.patch, HBASE-8963.trunk.v5.patch, HBASE-8963.trunk.v6.patch, HBASE-8963.trunk.v7.patch
> Currently HFileArchiver is always called when a table is dropped.
> A configuration option (either global or per table) should be provided so that archiving
can be skipped when table is deleted.

This message was sent by Atlassian JIRA

View raw message