hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8963) Add configuration option to skip HFile archiving
Date Thu, 13 Mar 2014 20:29:48 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13934004#comment-13934004
] 

Ted Yu commented on HBASE-8963:
-------------------------------

{code}
+  private static final String HFILE_SKIP_ARCHIVE_CONF = "hbase.hfile.skip.archive";
{code}
Should the constant be named HFILE_SKIP_ARCHIVE_CONF_KEY ? It is key to the new config, right
?

For initCleaners(), null check on snapshotCleaner alone would be enough because both cleaners
would be instantiated, right ?
{code}
+              if(fs.delete(currentFile.getPath())){
+                  return true;
+              }
+              else{
+                  LOG.debug("Attempt to delete file "+currentFile.getPath().getName()+" failed.
Moving it to the archive.");
{code}
Suggest changing the log level to error.

License header is needed for TestSkipArchiveTableDeleteHandler.java
In that file, indentation is not right - 2 spaces should be used for each indent.
{code}
+        rs.close();
+        }finally {
+            rs.close();
{code}
rs is closed twice, right ?

Thanks for taking this JIRA.

> Add configuration option to skip HFile archiving
> ------------------------------------------------
>
>                 Key: HBASE-8963
>                 URL: https://issues.apache.org/jira/browse/HBASE-8963
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: bharath v
>         Attachments: HBASE-8963.trunk.v1.patch, HBASE-8963.trunk.v2.patch, HBASE-8963.trunk.v3.patch
>
>
> Currently HFileArchiver is always called when a table is dropped.
> A configuration option (either global or per table) should be provided so that archiving
can be skipped when table is deleted.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message