hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5175) Add DoubleColumnInterpreter
Date Sat, 15 Mar 2014 23:02:43 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13936334#comment-13936334
] 

Ted Yu commented on HBASE-5175:
-------------------------------

Some nits:
{code}
+   @Override
+  public Double add(Double d1, Double d2) {
{code}
@Override should align with the start of 'p' in public.
{code}
+    } else if (d1 == null) // both are null
+      return null;
{code}
'else' is not needed. Please enclose 'return null;' in braces.
{code}
Running org.apache.hadoop.hbase.coprocessor.TestDoubleColumnInterpreter
Tests run: 38, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 25.34 sec
{code}
Good, new test passed.
{code}
+  @Test(timeout = 300000)
+  public void testMaxWithValidRange2WithNoCQ() throws Throwable {
{code}
We don't need such long timeout, right ?

+    } catch (Throwable e) {
+    }

Why is Throwable ignored ?
The long line warnings were for protobuf generated code.

> Add DoubleColumnInterpreter
> ---------------------------
>
>                 Key: HBASE-5175
>                 URL: https://issues.apache.org/jira/browse/HBASE-5175
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Ted Yu
>            Assignee: Julian Wissmann
>              Labels: aggregator, features
>             Fix For: 0.99.0
>
>         Attachments: DoubleColumnInterpreter.java, DoubleColumnInterpreter.patch, DoubleColumnInterpreterV2.patch,
DoubleColumnInterpreterV3.patch, HBase.proto, TestDoubleColumnInterpreter.java
>
>
> DoubleColumnInterpreter was requested by Royston Sellman.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message