hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5175) Add DoubleColumnInterpreter
Date Sun, 23 Mar 2014 16:01:44 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13944456#comment-13944456
] 

Anoop Sam John commented on HBASE-5175:
---------------------------------------

Overall looks good.
Instead of the deprecated method can you implement public T getValue(byte[] colFamily, byte[]
colQualifier, Cell c). No diff in impl code needed.

{code}
+   if (d1 == null ^ d2 == null) {
+      return (d1 == null) ? d2 : d1; // either of one is null.
+    } 
+    if (d1 == null) {// both are null
+      return null;
+    }
{code}
This would be enough I guess.
{code}
+    if (d1 == null || d2 == null) {
+      return (d1 == null) ? d2 : d1; 
+    }
{code}


> Add DoubleColumnInterpreter
> ---------------------------
>
>                 Key: HBASE-5175
>                 URL: https://issues.apache.org/jira/browse/HBASE-5175
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Ted Yu
>            Assignee: Julian Wissmann
>              Labels: aggregator, features
>             Fix For: 0.99.0
>
>         Attachments: DoubleColumnInterpreter.java, DoubleColumnInterpreter.patch, DoubleColumnInterpreterV2.patch,
DoubleColumnInterpreterV3.patch, DoubleColumnInterpreterV4.patch, HBase.proto, TestDoubleColumnInterpreter.java
>
>
> DoubleColumnInterpreter was requested by Royston Sellman.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message