hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Hofhansl (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4012) Further optimize byte comparison methods
Date Sat, 15 Mar 2014 05:11:43 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935995#comment-13935995
] 

Lars Hofhansl commented on HBASE-4012:
--------------------------------------

I did some - entirely unscientific - tests on this a while ago, and in my scenarios there
was no measurable difference between the two implementations (naive byte[] compare and the
unsafe code).


> Further optimize byte comparison methods
> ----------------------------------------
>
>                 Key: HBASE-4012
>                 URL: https://issues.apache.org/jira/browse/HBASE-4012
>             Project: HBase
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: 0.92.0
>            Reporter: Todd Lipcon
>            Assignee: Ted Yu
>            Priority: Minor
>              Labels: noob
>             Fix For: 0.92.0
>
>         Attachments: 4012-v2.txt, 4012.txt
>
>
> Guava uses some clever tricks with sun.misc.Unsafe to compare byte arrays about 100%
faster than the naive byte-by-byte implementation: http://guava-libraries.googlecode.com/svn/trunk/guava/src/com/google/common/primitives/UnsignedBytes.java
> We should borrow this [Apache 2 licensed] code.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message