Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 53715103EA for ; Thu, 27 Feb 2014 08:42:23 +0000 (UTC) Received: (qmail 24423 invoked by uid 500); 27 Feb 2014 08:42:22 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 24203 invoked by uid 500); 27 Feb 2014 08:42:19 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 24192 invoked by uid 99); 27 Feb 2014 08:42:19 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Feb 2014 08:42:19 +0000 Date: Thu, 27 Feb 2014 08:42:19 +0000 (UTC) From: "Anoop Sam John (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-10627) A logic mistake in HRegionServer isHealthy MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-10627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13914220#comment-13914220 ] Anoop Sam John commented on HBASE-10627: ---------------------------------------- Oh!! Can u attach a patch for the fix. Thanks for reporting. > A logic mistake in HRegionServer isHealthy > ------------------------------------------ > > Key: HBASE-10627 > URL: https://issues.apache.org/jira/browse/HBASE-10627 > Project: HBase > Issue Type: Bug > Reporter: Liu Shaohui > Priority: Minor > > After visiting the isHealthy in HRegionServer, I think there is a logic mistake. > {code} > // Verify that all threads are alive > if (!(leases.isAlive() > && cacheFlusher.isAlive() && hlogRoller.isAlive() > && this.compactionChecker.isAlive()) <---- logic wrong here > && this.periodicFlusher.isAlive()) { > stop("One or more threads are no longer alive -- stop"); > return false; > } > {code} > which should be > {code} > // Verify that all threads are alive > if (!(leases.isAlive() > && cacheFlusher.isAlive() && hlogRoller.isAlive() > && this.compactionChecker.isAlive() > && this.periodicFlusher.isAlive())) { > stop("One or more threads are no longer alive -- stop"); > return false; > } > {code} > Please finger out if i am wrong. Thx -- This message was sent by Atlassian JIRA (v6.1.5#6160)