Return-Path: 
 <issues-return-137082-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 3F04C10D07
	for <apmail-hbase-issues-archive@www.apache.org>;
 Wed, 26 Feb 2014 01:39:26 +0000 (UTC)
Received: (qmail 12275 invoked by uid 500); 26 Feb 2014 01:39:23 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 12223 invoked by uid 500); 26 Feb 2014 01:39:22 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 12137 invoked by uid 99); 26 Feb 2014 01:39:21 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Feb 2014 01:39:21 +0000
Date: Wed, 26 Feb 2014 01:39:21 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12697118.1393335116834.105746.1393378761665@arcas>
In-Reply-To: <JIRA.12697118.1393335116834@arcas>
References: <JIRA.12697118.1393335116834@arcas>
Subject: [jira] [Commented] (HBASE-10604) Fix parseArgs javadoc
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HBASE-10604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13912386#comment-13912386 ] 

Hudson commented on HBASE-10604:
--------------------------------

FAILURE: Integrated in hbase-0.96-hadoop2 #216 (See [https://builds.apache.org/job/hbase-0.96-hadoop2/216/])
HBASE-10604 Fix parseArgs javadoc (Jean-Marc Spaggiari) (stack: rev 1571811)
* /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/util/Merge.java


> Fix parseArgs javadoc
> ---------------------
>
>                 Key: HBASE-10604
>                 URL: https://issues.apache.org/jira/browse/HBASE-10604
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Marc Spaggiari
>            Assignee: Jean-Marc Spaggiari
>            Priority: Minor
>             Fix For: 0.96.2, 0.98.1, 0.99.0
>
>         Attachments: HBASE-10604-v0-trunk.patch
>
>
> Javadoc for parseArgs is a cut&past of previous method and need to be fixed.
> {code}
>   /*
>    * Adds a region's meta information from the passed <code>meta</code>
>    * region.
>    *
>    * @param metainfo hbase:meta HRegionInfo to be updated
>    * @param region HRegion to add to <code>meta</code>
>    *
>    * @throws IOException
>    */
>   private int parseArgs(String[] args) throws IOException {
>     GenericOptionsParser parser =
>       new GenericOptionsParser(getConf(), args);
>     String[] remainingArgs = parser.getRemainingArgs();
>     if (remainingArgs.length != 3) {
>       usage();
>       return -1;
>     }
>     tableName = TableName.valueOf(remainingArgs[0]);
>     region1 = Bytes.toBytesBinary(remainingArgs[1]);
>     region2 = Bytes.toBytesBinary(remainingArgs[2]);
>     int status = 0;
>     if (notInTable(tableName, region1) || notInTable(tableName, region2)) {
>       status = -1;
>     } else if (Bytes.equals(region1, region2)) {
>       LOG.error("Can't merge a region with itself");
>       status = -1;
>     }
>     return status;
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)