Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6228210D29 for ; Tue, 25 Feb 2014 19:32:28 +0000 (UTC) Received: (qmail 98926 invoked by uid 500); 25 Feb 2014 19:32:21 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 98863 invoked by uid 500); 25 Feb 2014 19:32:21 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 98760 invoked by uid 99); 25 Feb 2014 19:32:20 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Feb 2014 19:32:20 +0000 Date: Tue, 25 Feb 2014 19:32:20 +0000 (UTC) From: "Jean-Marc Spaggiari (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-10604) Fix parseArgs javadoc MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-10604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Marc Spaggiari updated HBASE-10604: ---------------------------------------- Attachment: (was: HBASE-10604-v0-trunk.patch) > Fix parseArgs javadoc > --------------------- > > Key: HBASE-10604 > URL: https://issues.apache.org/jira/browse/HBASE-10604 > Project: HBase > Issue Type: Bug > Reporter: Jean-Marc Spaggiari > Assignee: Jean-Marc Spaggiari > Priority: Minor > Attachments: HBASE-10604-v0-trunk.patch > > > Javadoc for parseArgs is a cut&past of previous method and need to be fixed. > {code} > /* > * Adds a region's meta information from the passed meta > * region. > * > * @param metainfo hbase:meta HRegionInfo to be updated > * @param region HRegion to add to meta > * > * @throws IOException > */ > private int parseArgs(String[] args) throws IOException { > GenericOptionsParser parser = > new GenericOptionsParser(getConf(), args); > String[] remainingArgs = parser.getRemainingArgs(); > if (remainingArgs.length != 3) { > usage(); > return -1; > } > tableName = TableName.valueOf(remainingArgs[0]); > region1 = Bytes.toBytesBinary(remainingArgs[1]); > region2 = Bytes.toBytesBinary(remainingArgs[2]); > int status = 0; > if (notInTable(tableName, region1) || notInTable(tableName, region2)) { > status = -1; > } else if (Bytes.equals(region1, region2)) { > LOG.error("Can't merge a region with itself"); > status = -1; > } > return status; > } > {code} -- This message was sent by Atlassian JIRA (v6.1.5#6160)