Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6391810C43 for ; Wed, 26 Feb 2014 22:04:25 +0000 (UTC) Received: (qmail 80911 invoked by uid 500); 26 Feb 2014 22:04:21 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 80837 invoked by uid 500); 26 Feb 2014 22:04:20 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 80826 invoked by uid 99); 26 Feb 2014 22:04:20 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Feb 2014 22:04:20 +0000 Date: Wed, 26 Feb 2014 22:04:20 +0000 (UTC) From: "Nick Dimiduk (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-10592) Refactor PerformanceEvaluation tool MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-10592: --------------------------------- Resolution: Fixed Fix Version/s: 0.98.1 0.96.2 Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) [~jmspaggi] thanks for taking it for a spin! I've committed to all three branches. Thanks for the reviews folks. > Refactor PerformanceEvaluation tool > ----------------------------------- > > Key: HBASE-10592 > URL: https://issues.apache.org/jira/browse/HBASE-10592 > Project: HBase > Issue Type: Improvement > Components: test > Affects Versions: 0.96.2, 0.98.1, 0.99.0 > Reporter: Nick Dimiduk > Assignee: Nick Dimiduk > Priority: Minor > Fix For: 0.96.2, 0.98.1, 0.99.0 > > Attachments: HBASE-10592.00-0.96.patch, HBASE-10592.00-0.98.patch, HBASE-10592.00.patch, HBASE-10592.01-0.96.patch, HBASE-10592.01-0.98.patch, HBASE-10592.01.patch > > > PerfEval is kind of a mess. It's painful to add new features because the test options are itemized and passed as parameters to internal methods. Serialization is hand-rolled and tedious. Ensuring support for mapreduce mode is a chore because of it. > This patch refactors the tool. Options are now passed around to methods and such as a POJO instead of one-by-one. Get rid of accessors that don't help anyone. On the mapreduce side, serialization is now handled using json (jackson is a dependency anyway) instead of the hand-rolled regex we used before. Also do away with custom InputSplit and FileFormat, instead using Text and NLineInputFormat. On the local mode side, combine 1 client and N clients into the same implementation. That implementation now uses an ExecutorService, so we can later decouple number of client workers from number of client tasks. Finally, drop a bunch of confusing local state, instead use the new TestOptions POJO as a parameter to static methods. -- This message was sent by Atlassian JIRA (v6.1.5#6160)