Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E20F310BB3 for ; Fri, 21 Feb 2014 13:03:26 +0000 (UTC) Received: (qmail 62439 invoked by uid 500); 21 Feb 2014 13:03:24 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 62215 invoked by uid 500); 21 Feb 2014 13:03:23 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 61645 invoked by uid 99); 21 Feb 2014 13:03:21 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Feb 2014 13:03:21 +0000 Date: Fri, 21 Feb 2014 13:03:21 +0000 (UTC) From: "Ted Yu (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-10585) Avoid early creation of Node objects in LRUDictionary.BidirectionalLRUMap MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13908274#comment-13908274 ] Ted Yu commented on HBASE-10585: -------------------------------- +1 > Avoid early creation of Node objects in LRUDictionary.BidirectionalLRUMap > ------------------------------------------------------------------------- > > Key: HBASE-10585 > URL: https://issues.apache.org/jira/browse/HBASE-10585 > Project: HBase > Issue Type: Bug > Reporter: Anoop Sam John > Assignee: Anoop Sam John > Fix For: 0.98.1, 0.99.0 > > Attachments: HBASE-10585.patch > > > When LRUDictionary initialized with N as the size, the BidirectionalLRUMap creates N Node objects and kept in an array. It will be better not doing this eager creation. Can create Node object on demand if array's current position Node element is null. Once it is created the object can be reused as we do now. -- This message was sent by Atlassian JIRA (v6.1.5#6160)