Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 27 Feb 2014 21:39:20 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12696241.1392903524812.120553.1393537160612@arcas>
In-Reply-To: <JIRA.12696241.1392903524812@arcas>
References: <JIRA.12696241.1392903524812@arcas>
Subject: [jira] [Commented] (HBASE-10576) Custom load balancer to co-locate
 the regions of two tables which are having same split keys
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-10576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13915076#comment-13915076 ] 

Ted Yu commented on HBASE-10576:
--------------------------------

Please fix the 2 new findbugs warnings - HBASE-10624 covers the other two.
{code}
+  private static final Random RANDOM = new Random(System.currentTimeMillis());
{code}
Use EnvironmentEdge above.
{code}
+      Map<ImmutableBytesWritable, ServerName> tabkeKeys = this.colocationInfo.get(tableName);
{code}
We should move away from Writables, right ?

In getServerNameFromMap():
{code}
+    TableName mappedTable = getMappedTableToColocate(regionInfo.getTable());
{code}
What if mappedTable is the same as tableName ?

> Custom load balancer to co-locate the regions of two tables which are having same split keys
> --------------------------------------------------------------------------------------------
>
>                 Key: HBASE-10576
>                 URL: https://issues.apache.org/jira/browse/HBASE-10576
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Balancer
>            Reporter: rajeshbabu
>            Assignee: rajeshbabu
>         Attachments: HBASE-10576.patch
>
>
> To support local indexing both user table and index table should have same split keys. This issue to provide custom balancer to colocate the regions of two tables which are having same split keys. 
> This helps in Phoenix as well.


--
This message was sent by Atlassian JIRA
(v6.1.5#6160)