Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BE09210E32 for ; Tue, 18 Feb 2014 23:23:37 +0000 (UTC) Received: (qmail 56152 invoked by uid 500); 18 Feb 2014 23:23:22 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 56121 invoked by uid 500); 18 Feb 2014 23:23:21 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 56110 invoked by uid 99); 18 Feb 2014 23:23:21 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Feb 2014 23:23:21 +0000 Date: Tue, 18 Feb 2014 23:23:21 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-10539) HRegion.addAndGetGlobalMemstoreSize returns previous size MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-10539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13904788#comment-13904788 ] Hudson commented on HBASE-10539: -------------------------------- SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #154 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/154/]) HBASE-10539. HRegion.addAndGetGlobalMemstoreSize returns previous size (Feng Honghua) (apurtell: rev 1569472) * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > HRegion.addAndGetGlobalMemstoreSize returns previous size > --------------------------------------------------------- > > Key: HBASE-10539 > URL: https://issues.apache.org/jira/browse/HBASE-10539 > Project: HBase > Issue Type: Bug > Components: regionserver > Reporter: Feng Honghua > Assignee: Feng Honghua > Fix For: 0.96.2, 0.98.1, 0.99.0, 0.94.17 > > Attachments: HBASE-10539-trunk_v1.patch > > > HRegion.addAndGetGlobalMemstoreSize(addedSize) is called once some write succeeds and 'addedSize' is the size of the edits newly put to the memstore, the returned value of HRegion.addAndGetGlobalMemstoreSize(addedSize) is then checked against the flush threshold to determine if a flush for the region should be triggered. > By design the returned value should be the updated memstore size after adding 'addedSize', but current implementation uses this.memstoreSize.getAndAdd which returns the previous size before adding, actually 'addAndGet' rather than 'getAndAdd' should be used here. -- This message was sent by Atlassian JIRA (v6.1.5#6160)