Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 458F710E53 for ; Wed, 12 Feb 2014 04:30:31 +0000 (UTC) Received: (qmail 65859 invoked by uid 500); 12 Feb 2014 04:30:26 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 65724 invoked by uid 500); 12 Feb 2014 04:30:22 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 65689 invoked by uid 99); 12 Feb 2014 04:30:21 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Feb 2014 04:30:21 +0000 Date: Wed, 12 Feb 2014 04:30:21 +0000 (UTC) From: "ramkrishna.s.vasudevan (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-10505) Import.filterKv does not call Filter.filterRowKey MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13898779#comment-13898779 ] ramkrishna.s.vasudevan commented on HBASE-10505: ------------------------------------------------ [~lhofhansl] Patch looks good to me. Can we try adding a filter testcase in testimportExport that validates this behaviour. The current test as you said my be just passing. Even sometime back I found that the testcases in TestImport were just passing without actually getting any KVs. So add a testcase for this behaviour. If it takes time, then we can address in a seperate JIRA. +1 on patch. > Import.filterKv does not call Filter.filterRowKey > ------------------------------------------------- > > Key: HBASE-10505 > URL: https://issues.apache.org/jira/browse/HBASE-10505 > Project: HBase > Issue Type: Bug > Reporter: Lars Hofhansl > Assignee: Lars Hofhansl > Priority: Critical > Fix For: 0.96.2, 0.94.17 > > Attachments: 10505-0.94-v2.txt, 10505-0.94.txt, 10505-0.96-v2.txt > > > The general contract of a Filter is that filterRowKey is called before filterKeyValue. > Import is using Filters for custom filtering but it does not called filterRowKey at all. That throws off some Filters (such as RowFilter, and more recently PrefixFilter, and InclusiveStopFilter). See HBASE-10493 and HBASE-10485. -- This message was sent by Atlassian JIRA (v6.1.5#6160)