Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 12 Feb 2014 14:15:22 +0000 (UTC)
From: "Nicolas Liochon (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12694305.1392053833831.30513.1392214522287@arcas>
In-Reply-To: <JIRA.12694305.1392053833831@arcas>
References: <JIRA.12694305.1392053833831@arcas>
Subject: [jira] [Commented] (HBASE-10490) Simplify RpcClient code
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-10490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899132#comment-13899132 ] 

Nicolas Liochon commented on HBASE-10490:
-----------------------------------------

As well, a rpcTimeout set to 0 might still work, or at least still work as it used to. The code around timeout is still difficult. I kept the ThreadLocal, but this code scares me, and clearly does not work for all cases. It's an issue for me, because when something goes wrong here I'm never sure it does not come from a race condition. As well, for example, we can set very low timeouts.  So the cleanup on timeout is not in this jira, but will have to be done a day for sure.

Anyway, here a a v2 with the typo fixed and the removal of the closeReason.

Thanks for the feedback....


> Simplify RpcClient code
> -----------------------
>
>                 Key: HBASE-10490
>                 URL: https://issues.apache.org/jira/browse/HBASE-10490
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.99.0
>            Reporter: Nicolas Liochon
>            Assignee: Nicolas Liochon
>             Fix For: 0.99.0
>
>         Attachments: 10490.v1.patch
>
>
> The code is complex. Here is a set of proposed changes, for trunk:
> 1) remove PingInputStream. if rpcTimeout > 0 it just rethrows the exception. I expect that we always have a rpcTimeout. So we can remove the code.
> 2) remove the sendPing: instead, just close the connection if it's not used for a while, instead of trying to ping the server.
> 3) remove maxIddle time: to avoid the confusion if someone has overwritten the conf.
> 4) remove shouldCloseConnection: it was more or less synchronized with closeException. Having a single variable instead of two avoids the synchro
> 5) remove lastActivity: instead of trying to have an exact timeout, just kill the connection after some time. lastActivity could be set to wrong values if the server was slow to answer.
> 6) hopefully, a better management of the exception; we don't use the close exception of someone else as an input for another one.  Same goes for interruption.
> I may have something wrong in the code. I will review it myself again. Feedback welcome, especially on the ping removal: I hope I got all the use cases. 


--
This message was sent by Atlassian JIRA
(v6.1.5#6160)