Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 12 Feb 2014 03:23:21 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12694090.1391859532763.28521.1392175401556@arcas>
In-Reply-To: <JIRA.12694090.1391859532763@arcas>
References: <JIRA.12694090.1391859532763@arcas>
Subject: [jira] [Commented] (HBASE-10487) Avoid allocating new KeyValue and
 according bytes-copying for appended kvs which don't have existing values
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-10487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13898731#comment-13898731 ] 

Hadoop QA commented on HBASE-10487:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12628416/HBASE-10487-0.98_v1.patch
  against trunk revision .
  ATTACHMENT ID: 12628416

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified tests.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8666//console

This message is automatically generated.

> Avoid allocating new KeyValue and according bytes-copying for appended kvs which don't have existing values
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-10487
>                 URL: https://issues.apache.org/jira/browse/HBASE-10487
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Feng Honghua
>            Assignee: Feng Honghua
>             Fix For: 0.99.0
>
>         Attachments: HBASE-10487-0.98_v1.patch, HBASE-10487-trunk_v1.patch
>
>
> in HRegion.append, new KeyValues will be allocated and do according bytes-copying no matter whether there are existing kv for the appended cells, we can improve here by avoiding the allocating of new KeyValue and according bytes-copying for kv which don't have existing(old) values by reusing the passed-in kv and only updating its timestamp to 'now'(its original timestamp is latest, so can be updated)


--
This message was sent by Atlassian JIRA
(v6.1.5#6160)