Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F01D810482 for ; Tue, 11 Feb 2014 02:37:33 +0000 (UTC) Received: (qmail 73122 invoked by uid 500); 11 Feb 2014 02:37:32 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 72934 invoked by uid 500); 11 Feb 2014 02:37:29 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 72776 invoked by uid 99); 11 Feb 2014 02:37:26 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Feb 2014 02:37:26 +0000 Date: Tue, 11 Feb 2014 02:37:26 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-10485) PrefixFilter#filterKeyValue() should perform filtering on row key MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13897471#comment-13897471 ] Hudson commented on HBASE-10485: -------------------------------- SUCCESS: Integrated in HBase-TRUNK #4906 (See [https://builds.apache.org/job/HBase-TRUNK/4906/]) HBASE-10485 PrefixFilter#filterKeyValue() should perform filtering on row key (tedyu: rev 1566912) * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/PrefixFilter.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java HBASE-10485 Revert to address more review comments (tedyu: rev 1566869) * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/PrefixFilter.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterListAdditional.java > PrefixFilter#filterKeyValue() should perform filtering on row key > ----------------------------------------------------------------- > > Key: HBASE-10485 > URL: https://issues.apache.org/jira/browse/HBASE-10485 > Project: HBase > Issue Type: Bug > Reporter: Ted Yu > Assignee: Ted Yu > Fix For: 0.96.2, 0.98.1, 0.99.0, 0.94.17 > > Attachments: 10485-0.94-v2.txt, 10485-0.94.txt, 10485-trunk-v2.txt, 10485-trunk.addendum, 10485-v1.txt > > > Niels reported an issue under the thread 'Trouble writing custom filter for use in FilterList' where his custom filter used in FilterList along with PrefixFilter produced an unexpected results. > His test can be found here: > https://github.com/nielsbasjes/HBase-filter-problem > This is due to PrefixFilter#filterKeyValue() using FilterBase#filterKeyValue() which returns ReturnCode.INCLUDE > When FilterList.Operator.MUST_PASS_ONE is specified, FilterList#filterKeyValue() would return ReturnCode.INCLUDE even when row key prefix doesn't match meanwhile the other filter's filterKeyValue() returns ReturnCode.NEXT_COL -- This message was sent by Atlassian JIRA (v6.1.5#6160)