Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AB57410E83 for ; Fri, 7 Feb 2014 23:01:25 +0000 (UTC) Received: (qmail 10817 invoked by uid 500); 7 Feb 2014 23:01:24 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 10786 invoked by uid 500); 7 Feb 2014 23:01:24 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 10769 invoked by uid 99); 7 Feb 2014 23:01:24 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Feb 2014 23:01:24 +0000 Date: Fri, 7 Feb 2014 23:01:24 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-10480) TestLogRollPeriod#testWithEdits may fail due to insufficient waiting MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13895203#comment-13895203 ] Hudson commented on HBASE-10480: -------------------------------- FAILURE: Integrated in HBase-0.94-on-Hadoop-2 #12 (See [https://builds.apache.org/job/HBase-0.94-on-Hadoop-2/12/]) HBASE-10480 TestLogRollPeriod#testWithEdits may fail due to insufficient waiting (mbertozzi: rev 1565776) * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollPeriod.java > TestLogRollPeriod#testWithEdits may fail due to insufficient waiting > -------------------------------------------------------------------- > > Key: HBASE-10480 > URL: https://issues.apache.org/jira/browse/HBASE-10480 > Project: HBase > Issue Type: Test > Components: test > Reporter: Ted Yu > Assignee: Matteo Bertozzi > Priority: Minor > Fix For: 0.98.0, 0.96.2, 0.99.0, 0.94.17 > > Attachments: HBASE-10480-v0.patch > > > The test waits for minRolls rolls by sleeping: > {code} > Thread.sleep((minRolls + 1) * LOG_ROLL_PERIOD); > {code} > However, the above wait period may not be sufficient. > See https://builds.apache.org/job/HBase-TRUNK/4895/testReport/junit/org.apache.hadoop.hbase.regionserver.wal/TestLogRollPeriod/testWithEdits/ : > {code} > 2014-02-06 23:02:25,710 DEBUG [RS:0;quirinus:56476.logRoller] regionserver.LogRoller(87): Hlog roll period 4000ms elapsed > ... > 2014-02-06 23:02:30,275 DEBUG [RS:0;quirinus:56476.logRoller] regionserver.LogRoller(87): Hlog roll period 4000ms elapsed > {code} > The interval between two successive periodic rolls was ~1.5s longer than LOG_ROLL_PERIOD (4s) > 1.5s * 4 (minRolls-1) > 4s (LOG_ROLL_PERIOD) > This led to the test failure: > {code} > java.lang.AssertionError > at org.junit.Assert.fail(Assert.java:86) > at org.junit.Assert.assertTrue(Assert.java:41) > at org.junit.Assert.assertFalse(Assert.java:64) > at org.junit.Assert.assertFalse(Assert.java:74) > at org.apache.hadoop.hbase.regionserver.wal.TestLogRollPeriod.checkMinLogRolls(TestLogRollPeriod.java:168) > at org.apache.hadoop.hbase.regionserver.wal.TestLogRollPeriod.testWithEdits(TestLogRollPeriod.java:130) > {code} -- This message was sent by Atlassian JIRA (v6.1.5#6160)