Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DAD4110AE0 for ; Tue, 4 Feb 2014 03:40:12 +0000 (UTC) Received: (qmail 59533 invoked by uid 500); 4 Feb 2014 03:40:10 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 59498 invoked by uid 500); 4 Feb 2014 03:40:10 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 59489 invoked by uid 99); 4 Feb 2014 03:40:09 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Feb 2014 03:40:09 +0000 Date: Tue, 4 Feb 2014 03:40:09 +0000 (UTC) From: "Anoop Sam John (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-10461) table.close() in TableEventHandler#reOpenAllRegions() should be enclosed in finally block MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890339#comment-13890339 ] Anoop Sam John commented on HBASE-10461: ---------------------------------------- +1 Nit : Avoid the white spaces (Last line in the patch) on commit. > table.close() in TableEventHandler#reOpenAllRegions() should be enclosed in finally block > ----------------------------------------------------------------------------------------- > > Key: HBASE-10461 > URL: https://issues.apache.org/jira/browse/HBASE-10461 > Project: HBase > Issue Type: Bug > Reporter: Ted Yu > Priority: Minor > Fix For: 0.98.0, 0.99.0 > > Attachments: 10461-v1.txt > > > If table.getRegionLocations() throws exception, table.close() would be skipped, leaking the underlying resource -- This message was sent by Atlassian JIRA (v6.1.5#6160)