Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A7A9A10B15 for ; Wed, 5 Feb 2014 00:38:27 +0000 (UTC) Received: (qmail 83166 invoked by uid 500); 5 Feb 2014 00:38:20 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 83103 invoked by uid 500); 5 Feb 2014 00:38:18 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 82988 invoked by uid 99); 5 Feb 2014 00:38:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Feb 2014 00:38:13 +0000 Date: Wed, 5 Feb 2014 00:38:13 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-10454) Tags presence file info can be wrong in HFiles when PrefixTree encoding is used MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-10454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13891525#comment-13891525 ] Hudson commented on HBASE-10454: -------------------------------- SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #120 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/120/]) HBASE-10454 Tags presence file info can be wrong in HFiles when PrefixTree encoding is used. (anoopsamjohn: rev 1564385) * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV3.java > Tags presence file info can be wrong in HFiles when PrefixTree encoding is used > ------------------------------------------------------------------------------- > > Key: HBASE-10454 > URL: https://issues.apache.org/jira/browse/HBASE-10454 > Project: HBase > Issue Type: Bug > Affects Versions: 0.98.0 > Reporter: Anoop Sam John > Assignee: Anoop Sam John > Priority: Minor > Fix For: 0.98.0, 0.99.0 > > Attachments: HBASE-10454.patch, HBASE-10454_V2.patch > > > We always encode tags in case of Prefix tree now and so the code path, while decoding, not checking what is there in FileInfo. So functionally no issues now. > If we do HBASE-10453 this change will be very important to make sure BC for old files. > We use the file info MAX_TAGS_LEN to know the presence of tags in a file. In case of prefix tree we always have tags in files even if all kvs have 0 tags. So better we can add this file info into prefix tree encoded HFiles. Now it get missed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)