Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4508210BD8 for ; Tue, 4 Feb 2014 04:18:13 +0000 (UTC) Received: (qmail 2905 invoked by uid 500); 4 Feb 2014 04:18:12 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 2726 invoked by uid 500); 4 Feb 2014 04:18:10 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 2706 invoked by uid 99); 4 Feb 2014 04:18:10 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Feb 2014 04:18:10 +0000 Date: Tue, 4 Feb 2014 04:18:10 +0000 (UTC) From: "Anoop Sam John (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-10454) TAGS_COMPRESSED file info is wrong in HFiles when PrefixTree encoding is used MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-10454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890360#comment-13890360 ] Anoop Sam John commented on HBASE-10454: ---------------------------------------- With that compressed file info, I mean to add in the Prefix tree encoded HFiles the info, whether the file is containing tags as encoded or not. (Just see comment in HBASE-10454) As per the discussion there, no need to do that encoding condition based. Tag compression will happen only in encoded files for encoders other than Prefix tree. Fine. Will attach a patch which contains only the tag presence part. > TAGS_COMPRESSED file info is wrong in HFiles when PrefixTree encoding is used > ----------------------------------------------------------------------------- > > Key: HBASE-10454 > URL: https://issues.apache.org/jira/browse/HBASE-10454 > Project: HBase > Issue Type: Bug > Affects Versions: 0.98.0 > Reporter: Anoop Sam John > Assignee: Anoop Sam John > Fix For: 0.98.0 > > Attachments: HBASE-10454.patch > > > We always encode tags in case of Prefix tree now and so the code path, while decoding, not checking what is there in FileInfo. So functionally no issues now. > If we do HBASE-10453 this change will be very important to make sure BC for old files. -- This message was sent by Atlassian JIRA (v6.1.5#6160)