Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0BCB9106BE for ; Sat, 22 Feb 2014 00:18:30 +0000 (UTC) Received: (qmail 80170 invoked by uid 500); 22 Feb 2014 00:18:26 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 80121 invoked by uid 500); 22 Feb 2014 00:18:25 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 80096 invoked by uid 99); 22 Feb 2014 00:18:23 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 22 Feb 2014 00:18:23 +0000 Date: Sat, 22 Feb 2014 00:18:23 +0000 (UTC) From: "Brandon Li (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-8304) Bulkload fail to remove files if fs.default.name / fs.defaultFS is configured without default port. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-8304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13909028#comment-13909028 ] Brandon Li commented on HBASE-8304: ----------------------------------- {quote}+ if (desFs.getFileChecksum(tmpPath).equals(srcFs.getFileChecksum(srcPath)){quote} It will throw NPE if desFs doesn't overload FileSystem#getFileChecksum(). FileSystem#getCanonicalUri() can return a canonical path with port. However it's protected not public. You need to change it to public method first. > Bulkload fail to remove files if fs.default.name / fs.defaultFS is configured without default port. > --------------------------------------------------------------------------------------------------- > > Key: HBASE-8304 > URL: https://issues.apache.org/jira/browse/HBASE-8304 > Project: HBase > Issue Type: Bug > Components: HFile, regionserver > Affects Versions: 0.94.5 > Reporter: Raymond Liu > Labels: bulkloader > Attachments: HBASE-9537.patch > > > When fs.default.name or fs.defaultFS in hadoop core-site.xml is configured as hdfs://ip, and hbase.rootdir is configured as hdfs://ip:port/hbaserootdir where port is the hdfs namenode's default port. the bulkload operation will not remove the file in bulk output dir. Store::bulkLoadHfile will think hdfs:://ip and hdfs:://ip:port as different filesystem and go with copy approaching instead of rename. > The root cause is that hbase master will rewrite fs.default.name/fs.defaultFS according to hbase.rootdir when regionserver started, thus, dest fs uri from the hregion will not matching src fs uri passed from client. > any suggestion what is the best approaching to fix this issue? > I kind of think that we could check for default port if src uri come without port info. -- This message was sent by Atlassian JIRA (v6.1.5#6160)