hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10627) A logic mistake in HRegionServer isHealthy
Date Thu, 27 Feb 2014 12:08:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13914443#comment-13914443
] 

Hadoop QA commented on HBASE-10627:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12631495/HBASE-10627-trunk-v1.diff
  against trunk revision .
  ATTACHMENT ID: 12631495

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 1.0 profile.

    {color:green}+1 hadoop1.1{color}.  The patch compiles against the hadoop 1.1 profile.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 2 new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8832//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8832//console

This message is automatically generated.

> A logic mistake in HRegionServer isHealthy
> ------------------------------------------
>
>                 Key: HBASE-10627
>                 URL: https://issues.apache.org/jira/browse/HBASE-10627
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Liu Shaohui
>            Assignee: Liu Shaohui
>            Priority: Minor
>             Fix For: 0.96.2, 0.98.1, 0.99.0, 0.94.18
>
>         Attachments: HBASE-10627-0.94-v1.diff, HBASE-10627-trunk-v1.diff
>
>
> After visiting the isHealthy in HRegionServer, I think there is a logic mistake.
> {code}
>     // Verify that all threads are alive
>     if (!(leases.isAlive()
>         && cacheFlusher.isAlive() && hlogRoller.isAlive()
>         && this.compactionChecker.isAlive())   <---- logic wrong here
>         && this.periodicFlusher.isAlive()) {
>       stop("One or more threads are no longer alive -- stop");
>       return false;
>     }
> {code}
> which should be
> {code}
>     // Verify that all threads are alive
>     if (!(leases.isAlive()
>         && cacheFlusher.isAlive() && hlogRoller.isAlive()
>         && this.compactionChecker.isAlive()
>         && this.periodicFlusher.isAlive())) {
>       stop("One or more threads are no longer alive -- stop");
>       return false;
>     }
> {code}
> Please finger out if i am wrong. Thx



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message