hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10539) HRegion.addAndGetGlobalMemstoreSize returns previous size
Date Tue, 18 Feb 2014 21:25:24 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13904624#comment-13904624
] 

Hudson commented on HBASE-10539:
--------------------------------

FAILURE: Integrated in HBase-0.94-JDK7 #58 (See [https://builds.apache.org/job/HBase-0.94-JDK7/58/])
HBASE-10539 HRegion.addAndGetGlobalMemstoreSize returns previous size (stack: rev 1569480)
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java


> HRegion.addAndGetGlobalMemstoreSize returns previous size
> ---------------------------------------------------------
>
>                 Key: HBASE-10539
>                 URL: https://issues.apache.org/jira/browse/HBASE-10539
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Feng Honghua
>            Assignee: Feng Honghua
>             Fix For: 0.96.2, 0.98.1, 0.99.0, 0.94.17
>
>         Attachments: HBASE-10539-trunk_v1.patch
>
>
> HRegion.addAndGetGlobalMemstoreSize(addedSize) is called once some write succeeds and
'addedSize' is the size of the edits newly put to the memstore, the returned value of HRegion.addAndGetGlobalMemstoreSize(addedSize)
is then checked against the flush threshold to determine if a flush for the region should
be triggered.
> By design the returned value should be the updated memstore size after adding 'addedSize',
but current implementation uses this.memstoreSize.getAndAdd which returns the previous size
before adding, actually 'addAndGet' rather than 'getAndAdd' should be used here.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message