hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10532) Make KeyValueComparator in KeyValue to accept Cell instead of KeyValue.
Date Tue, 18 Feb 2014 23:09:23 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13904765#comment-13904765
] 

Enis Soztutar commented on HBASE-10532:
---------------------------------------

This looks good. In matchingRowColumn() we can just call compareRows() and compareColumns()
directly. Just a suggestion. 
Shall we do a CellComparator, which will not have any KV bits, and start using that internally?
What do you think. 

> Make KeyValueComparator in KeyValue to accept Cell instead of KeyValue.
> -----------------------------------------------------------------------
>
>                 Key: HBASE-10532
>                 URL: https://issues.apache.org/jira/browse/HBASE-10532
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.99.0
>
>         Attachments: HBASE-10532.patch, HBASE-10532.patch
>
>
> public int compareRows(final KeyValue left, final KeyValue right)
> public boolean matchingRows(final KeyValue left, final KeyValue right)
> We can make them to use Cells instead of KeyValue incase we need to use them for comparison
of any type of cell in future.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message