hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10531) Revisit how the key byte[] is passed to HFileScanner.seekTo and reseekTo
Date Wed, 19 Feb 2014 18:32:22 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13905815#comment-13905815

Anoop Sam John commented on HBASE-10531:

HFileScanner is @InterfaceAudience.Private   Still we have to do deprecate and then add new
API as overloaded? 
It will be better to add the alternate API to use along with @Deprecated.

nit : There are white spaces in the patch.

+      public int seekTo(Cell kv) throws IOException {
+        KeyValue keyValue = KeyValueUtil.ensureKeyValue(kv);
+        return seekTo(keyValue.getBuffer(), keyValue.getOffset(), keyValue.getLength());
+      }
You will avoid the refercence to keyValue.getBuffer() in coming patches?

In the code we still refer to deprecated API. Better we can use the new API now.   (?)

> Revisit how the key byte[] is passed to HFileScanner.seekTo and reseekTo
> ------------------------------------------------------------------------
>                 Key: HBASE-10531
>                 URL: https://issues.apache.org/jira/browse/HBASE-10531
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.99.0
>         Attachments: HBASE-10531.patch
> Currently the byte[] key passed to HFileScanner.seekTo and HFileScanner.reseekTo, is
a combination of row, cf, qual, type and ts.  And the caller forms this by using kv.getBuffer,
which is actually deprecated.  So see how this can be achieved considering kv.getBuffer is

This message was sent by Atlassian JIRA

View raw message