hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Corgan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10529) Make Cell extend Cloneable
Date Thu, 20 Feb 2014 07:26:24 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906705#comment-13906705
] 

Matt Corgan commented on HBASE-10529:
-------------------------------------

It feels a little strange for the long-term, but I don't see a problem with it for now.  My
concern being that clone() normally does a deep copy of all bytes that make up an object,
however a Cell is not really an object so much as a temporary view into memory.  Cell is an
interface, so which implementation should the caller expect from clone()?  I wonder if the
caller could instead do something more explicit like "new KeyValue(cell)".

> Make Cell extend Cloneable
> --------------------------
>
>                 Key: HBASE-10529
>                 URL: https://issues.apache.org/jira/browse/HBASE-10529
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.99.0
>
>         Attachments: HBSE-10529.patch
>
>
> Refer to the parent JIRA for discussion on making extending Cloneable.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message