hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10515) Potential null pointer dereference in HFileArchiver#archiveRegion()
Date Wed, 12 Feb 2014 22:40:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899703#comment-13899703
] 

stack commented on HBASE-10515:
-------------------------------

Did this come up in testing, actual use, or just random code reading?  I presume the latter.
 Correct me if I have it wrong.

> Potential null pointer dereference in HFileArchiver#archiveRegion()
> -------------------------------------------------------------------
>
>                 Key: HBASE-10515
>                 URL: https://issues.apache.org/jira/browse/HBASE-10515
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: 10515-v1.txt, 10515-v2.txt
>
>
> Here is related code:
> {code}
>     if (tableDir == null || regionDir == null) {
>       LOG.error("No archive directory could be found because tabledir (" + tableDir
>           + ") or regiondir (" + regionDir + "was null. Deleting files instead.");
>       deleteRegionWithoutArchiving(fs, regionDir);
> {code}
> When regionDir is null, calling deleteRegionWithoutArchiving() would lead to NPE in FileSystem.delete().



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message