hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10505) Import.filterKv does not call Filter.filterRowKey
Date Wed, 12 Feb 2014 04:30:21 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13898779#comment-13898779
] 

ramkrishna.s.vasudevan commented on HBASE-10505:
------------------------------------------------

[~lhofhansl]
Patch looks good to me.  Can we try adding a filter testcase in testimportExport that validates
this behaviour.  The current test as you said my be just passing.  Even sometime back I found
that the testcases in TestImport were just passing without actually getting any KVs.  So add
a testcase for this behaviour. If it takes time, then we can address in a seperate JIRA.
+1 on patch.

> Import.filterKv does not call Filter.filterRowKey
> -------------------------------------------------
>
>                 Key: HBASE-10505
>                 URL: https://issues.apache.org/jira/browse/HBASE-10505
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Critical
>             Fix For: 0.96.2, 0.94.17
>
>         Attachments: 10505-0.94-v2.txt, 10505-0.94.txt, 10505-0.96-v2.txt
>
>
> The general contract of a Filter is that filterRowKey is called before filterKeyValue.
> Import is using Filters for custom filtering but it does not called filterRowKey at all.
That throws off some Filters (such as RowFilter, and more recently PrefixFilter, and InclusiveStopFilter).
See HBASE-10493 and HBASE-10485.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message