hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Feng Honghua (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10497) Add according handling for swallowed InterruptedException thrown by Thread.sleep under HBase-Client/HBase-Server folders systematically
Date Tue, 11 Feb 2014 10:10:19 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13897694#comment-13897694
] 

Feng Honghua commented on HBASE-10497:
--------------------------------------

Threads.sleep()(which prints full call stack and call Thread.currentThread.interrupt) is also
a good alternative and it's used somewhere for this purpose, but maybe printing full call
stack is a bit more heavyweight than a one-line logging for most cases?

> Add according handling for swallowed InterruptedException thrown by Thread.sleep under
HBase-Client/HBase-Server folders systematically
> ---------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-10497
>                 URL: https://issues.apache.org/jira/browse/HBASE-10497
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client, regionserver
>            Reporter: Feng Honghua
>            Assignee: Feng Honghua
>            Priority: Minor
>         Attachments: HBASE-10497-trunk_v1.patch
>
>
> There are many places where InterruptedException thrown by Thread.sleep are swallowed
silently (which are neither declared in the caller method's throws clause nor rethrown immediately)
under HBase-Client/HBase-Server folders.
> It'd be better to add standard 'log and call currentThread.interrupt' for such cases.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message