hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matteo Bertozzi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10457) Print corrupted file information in SnapshotInfo tool without -file option
Date Mon, 03 Feb 2014 19:33:08 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13889801#comment-13889801
] 

Matteo Bertozzi commented on HBASE-10457:
-----------------------------------------

thanks for the patch.

you should probably:
 * replace the "if (showFiles || showStats) printFiles(showFiles)" with "printFiles(showFiles,
showStats)" and remove the first printFiles(false). 
 * use if (showStats) instead of showFiles for the "HFile (%d in archive) messages

> Print corrupted file information in SnapshotInfo tool without -file option
> --------------------------------------------------------------------------
>
>                 Key: HBASE-10457
>                 URL: https://issues.apache.org/jira/browse/HBASE-10457
>             Project: HBase
>          Issue Type: Improvement
>          Components: snapshots
>    Affects Versions: 0.99.0
>            Reporter: bharath v
>            Assignee: bharath v
>            Priority: Minor
>         Attachments: HBASE-10457-trunk-v0.patch
>
>
> Currently SnapshotInfo tool prints the corrupted snapshot information only if the user
provides -file options. This might mislead the user sometimes. This patch prints the corrupt
files information even without the -file option.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message