hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10455) cleanup InterruptedException management
Date Tue, 04 Feb 2014 14:34:10 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890722#comment-13890722
] 

Hudson commented on HBASE-10455:
--------------------------------

SUCCESS: Integrated in HBase-TRUNK #4880 (See [https://builds.apache.org/job/HBase-TRUNK/4880/])
HBASE-10455 cleanup InterruptedException management (nkeywal: rev 1564241)
* /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java
* /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java
* /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
* /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableUtil.java
* /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCaller.java
* /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/BlockingRpcCallback.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableMapReduceUtil.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/TableLockManager.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/TableNamespaceManager.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/MetaServerShutdownHandler.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java


> cleanup InterruptedException management
> ---------------------------------------
>
>                 Key: HBASE-10455
>                 URL: https://issues.apache.org/jira/browse/HBASE-10455
>             Project: HBase
>          Issue Type: Bug
>          Components: Client, master, regionserver
>    Affects Versions: 0.98.0, 0.99.0
>            Reporter: Nicolas Liochon
>            Assignee: Nicolas Liochon
>             Fix For: 0.98.0, 0.99.0
>
>         Attachments: 10455.v1.patch
>
>
> 4 changes in this code:
> 1) When caught and rethrowed as a IOException we always rethrow InterruptedIOException
> 2) When we were both throwing an exception AND resetting the interrupt status we only
throw an exception now.
> 3) When we were trying to reset the status by Thread.interrupted() (which does not do
that), we now do it for real with a Thread.currentThread.interrupt().
> 4) Sometimes, we were rethrowing something else then InterruptedIOException, while the
contract would have allowed it. I've changed this as well.
> This patch does not make means that we're fine when we're interrupted, but we're globally
cleaner at least. I will then create other patches specific to some parts.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message