hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10453) PrefixTree encoding for tags can honor HCD#shouldCompressTags()
Date Mon, 03 Feb 2014 19:19:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13889785#comment-13889785

Andrew Purtell commented on HBASE-10453:

bq. HCD#shouldCompressTags() is the wrong check for whether to include tags or not. It is
should *compress* tags.  That should only affect whether or not to use the (currently broken)
custom dictionary compression.

HCD is a public class so let's get this right before release.

> PrefixTree encoding for tags can honor HCD#shouldCompressTags()
> ---------------------------------------------------------------
>                 Key: HBASE-10453
>                 URL: https://issues.apache.org/jira/browse/HBASE-10453
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.0
>            Reporter: Anoop Sam John
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.98.1
> Right now we will encode tags always with prefix tree encoding. With other encoders it
checks HCD#shouldCompressTags().  Suggest we can do the same fro PrefixTree also.
> I can see some places PrefixTree impl passes booleans like isIncludeMvcc isIncludeTags
etc.  We have encapsulated all such info into a HFileContext and the code path uses that now.
 We can do the same with PrefixTree code path also.

This message was sent by Atlassian JIRA

View raw message