hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10451) Enable back Tag compression on HFiles
Date Fri, 21 Feb 2014 19:05:19 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13908684#comment-13908684
] 

Anoop Sam John commented on HBASE-10451:
----------------------------------------

TestEncodedSeekers  -> Locally it is passing (with out any hang) many times.  Though I
observed significant delay in run. The test creates some 100000+ Gets.  For every get we create
Scan and open Scanner for HFiles.  Each of this creates a LRUDictionary with size as Short.MAX_VALUE
and LRUDictionary  eagerly creates those many Node objects.  This kill us in the tests.
HBASE-10585 can solve this issue upto great extend.

Still I feel LRUDictionary size of Short.MAX_VALUE is too much for the Tag dict. This can
be Byte.MAX_VALUE IMO.   With these changes, the tests become much much faster.  Once I commit
HBASE-10585, will post the new patch here so as to get a QA run.

With the new patch the IntegrationTestIngestWithVisibilityLabels passing in cluster.  One
more thing is Integration tests creates the test tables using LTT -init_only option. LTT allows
to pass DBE etc to be used for the tables though the IntegrationTestIngest don't allow.  For
the above test I just patched IntegrationTestIngest  so as to make the table with FAST_DIFF
DBE.   Will open a new Jira so as to support passing table create options for the Integration
tests.

> Enable back Tag compression on HFiles
> -------------------------------------
>
>                 Key: HBASE-10451
>                 URL: https://issues.apache.org/jira/browse/HBASE-10451
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.0
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>            Priority: Critical
>             Fix For: 0.98.1, 0.99.0
>
>         Attachments: HBASE-10451.patch, HBASE-10451_V2.patch, HBASE-10451_V3.patch, HBASE-10451_V4.patch,
HBASE-10451_V5.patch
>
>
> HBASE-10443 disables tag compression on HFiles. This Jira is to fix the issues we have
found out in HBASE-10443 and enable it back.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message