Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AD9A010915 for ; Fri, 31 Jan 2014 21:28:18 +0000 (UTC) Received: (qmail 75761 invoked by uid 500); 31 Jan 2014 21:28:17 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 75721 invoked by uid 500); 31 Jan 2014 21:28:15 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 75707 invoked by uid 99); 31 Jan 2014 21:28:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 31 Jan 2014 21:28:12 +0000 Date: Fri, 31 Jan 2014 21:28:11 +0000 (UTC) From: "Lars Hofhansl (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-10447) Memstore flusher scans storefiles also when the scanner heap gets reset MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13888188#comment-13888188 ] Lars Hofhansl commented on HBASE-10447: --------------------------------------- So we can either revive the old constructor or pass down a flag. I'd prefer the latter approach, since it makes it explicit. > Memstore flusher scans storefiles also when the scanner heap gets reset > ----------------------------------------------------------------------- > > Key: HBASE-10447 > URL: https://issues.apache.org/jira/browse/HBASE-10447 > Project: HBase > Issue Type: Bug > Affects Versions: 0.98.0, 0.99.0, 0.96.1.1 > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Priority: Blocker > Fix For: 0.98.0, 0.96.2, 0.99.0 > > > See the mail thread > http://osdir.com/ml/general/2014-01/msg61294.html > In case of flush we create a memstore flusher which in turn creates a StoreScanner backed by a Single ton MemstoreScanner. > But this scanner also registers for any updates in the reader in the HStore. Is this needed? > If this happens then any update on the reader may nullify the current heap and the entire Scanner Stack is reset, but this time with the other scanners for all the files that satisfies the last top key. So the flush that happens on the memstore holds the storefile scanners also in the heap that was recreated but originally the intention was to create a scanner on the memstore alone. -- This message was sent by Atlassian JIRA (v6.1.5#6160)