Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 70F851037C for ; Fri, 24 Jan 2014 18:31:50 +0000 (UTC) Received: (qmail 99881 invoked by uid 500); 24 Jan 2014 18:31:45 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 99833 invoked by uid 500); 24 Jan 2014 18:31:44 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 99753 invoked by uid 99); 24 Jan 2014 18:31:41 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Jan 2014 18:31:41 +0000 Date: Fri, 24 Jan 2014 18:31:41 +0000 (UTC) From: "Andrew Purtell (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (HBASE-10412) Distributed log replay : Cell tags getting missed MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-10412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13881259#comment-13881259 ] Andrew Purtell edited comment on HBASE-10412 at 1/24/14 6:31 PM: ----------------------------------------------------------------- {quote} As Andy said: bq. We should fix this so we are not using a RPC codec for handling a WAL. That is surprising and wrong. Should be ok for now to just update javadoc, but I'm worried we'll start rolling in custom behavior for RPC that makes it very complicated. {quote} I agree. Looks like we are splitting this into two parts. 1. Get distributed log replay working with tags using a WALCodec. (Now) 2. Redo distributed replay a bit so it doesn't use a bare codec but uses its own. Maybe a RPC codec as static inner class that embeds a WAL codec? (Later) was (Author: apurtell): {quote} As Andy said: bq. We should fix this so we are not using a RPC codec for handling a WAL. That is surprising and wrong. Should be ok for now to just update javadoc, but I'm worried we'll start rolling in custom behavior for RPC that makes it very complicated. {quote} I agree. Looks like we are splitting this into two parts. 1. Get distributed log replay working with tags using a WALCodec. (Now) 2. Redo distributed splitting a bit so it doesn't use a bare codec but uses its own. Maybe a RPC codec as static inner class that embeds a WAL codec? (Later) > Distributed log replay : Cell tags getting missed > ------------------------------------------------- > > Key: HBASE-10412 > URL: https://issues.apache.org/jira/browse/HBASE-10412 > Project: HBase > Issue Type: Bug > Affects Versions: 0.98.0 > Reporter: Anoop Sam John > Assignee: Anoop Sam John > Priority: Blocker > Fix For: 0.98.0, 0.99.0 > > Attachments: HBASE-10412.patch > > > This is caused by HBASE-10322. The default RPC codec KVCodec strips tags. -- This message was sent by Atlassian JIRA (v6.1.5#6160)