Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4B6D910BE5 for ; Wed, 22 Jan 2014 09:22:23 +0000 (UTC) Received: (qmail 93028 invoked by uid 500); 22 Jan 2014 09:22:22 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 92843 invoked by uid 500); 22 Jan 2014 09:22:21 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 92822 invoked by uid 99); 22 Jan 2014 09:22:21 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Jan 2014 09:22:21 +0000 Date: Wed, 22 Jan 2014 09:22:21 +0000 (UTC) From: "cuijianwei (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-10395) endTime won't be set in VerifyReplication if startTime is not set MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-10395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] cuijianwei updated HBASE-10395: ------------------------------- Attachment: HBASE-10395-trunk-v2.patch HBASE-10395-0.94-v2.patch set endTime in replication Scan > endTime won't be set in VerifyReplication if startTime is not set > ----------------------------------------------------------------- > > Key: HBASE-10395 > URL: https://issues.apache.org/jira/browse/HBASE-10395 > Project: HBase > Issue Type: Improvement > Components: mapreduce, Replication > Affects Versions: 0.94.16 > Reporter: cuijianwei > Assignee: cuijianwei > Priority: Minor > Attachments: HBASE-10395-0.94-v1.patch, HBASE-10395-0.94-v2.patch, HBASE-10395-trunk-v1.patch, HBASE-10395-trunk-v2.patch > > > In VerifyReplication, we may set startTime and endTime to restrict the data to verfiy. However, the endTime won't be set in the program if we only pass endTime without startTime in command line argument. The reason is the following code: > {code} > if (startTime != 0) { > scan.setTimeRange(startTime, > endTime == 0 ? HConstants.LATEST_TIMESTAMP : endTime); > } > {code} > The code will ignore endTime setting when not passing startTime in command line argument. Another place needs to improvement is the help message as follows: > {code} > System.err.println(" stoprow end of the row"); > {code} > However, the program actually use "endrow" to parse the arguments: > {code} > final String endTimeArgKey = "--endtime="; > if (cmd.startsWith(endTimeArgKey)) { > endTime = Long.parseLong(cmd.substring(endTimeArgKey.length())); > continue; > } > {code} -- This message was sent by Atlassian JIRA (v6.1.5#6160)