Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 15 Jan 2014 11:25:19 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12688974.1389778241526.5512.1389785119746@arcas>
In-Reply-To: <JIRA.12688974.1389778241526@arcas>
References: <JIRA.12688974.1389778241526@arcas>
Subject: [jira] [Commented] (HBASE-10344) Improve write performance by
 ignoring sync to hdfs when an asyncer's writes have been synced by other
 asyncer
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-10344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13871944#comment-13871944 ] 

Hadoop QA commented on HBASE-10344:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12623101/HBASE-10344-trunk_v0.patch
  against trunk revision .
  ATTACHMENT ID: 12623101

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 1.0 profile.

    {color:green}+1 hadoop1.1{color}.  The patch compiles against the hadoop 1.1 profile.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:red}-1 site{color}.  The patch appears to cause mvn site goal to fail.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8435//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8435//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8435//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8435//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8435//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8435//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8435//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8435//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8435//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8435//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8435//console

This message is automatically generated.

> Improve write performance by ignoring sync to hdfs when an asyncer's writes have been synced by other asyncer
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-10344
>                 URL: https://issues.apache.org/jira/browse/HBASE-10344
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Feng Honghua
>            Assignee: Feng Honghua
>         Attachments: HBASE-10344-trunk_v0.patch
>
>
> By fixing [HBASE-10329|https://issues.apache.org/jira/browse/HBASE-10329], we know it's possible an asyncer's writes could have been synced by other asyncer before it starts to do the sync. We distinguish this case and handle accordingly when writer is null, but only for when writer is null.
> When writer is not null(the much more typical case), we also can check and ignore the sync if asyncer's writes have been synced by other asyncer before doing sync. Since sync is a quite heavy operation(together with the following notifying notifier thread and log roll check) we can have some performance gain by ignoring it for such case.


--
This message was sent by Atlassian JIRA
(v6.1.5#6160)